Skip to content

Commit b1baaff

Browse files
M-Vaittinenbroonie
authored andcommitted
regulator: bd71828-regulator.c: Fix LDON-HEAD mode
The ROHM BD72720 supports so called LDON-HEAD -mode, in which the buck10 is expected to be supplying power for an LDO. In this mode, the buck10 voltage will follow what is set for the LDO, on order to lower the power-loss in the LDO. This hardware configuration can be adverticed via the device-tree. When this is done, the Linux driver should omit registering the voltage control operations for the buck10, because the voltage control is now done by the hardware. This is done by modifying the buck10 regulator descriptor, before passing it to the regulator registration functions. There is an off-by-one error when the regulator descriptor array is indexed, and wrong descriptor is modified causing the LDO1 operations to be modified instead of the BUCK10 operations. Fix this by correcting the indexing. Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> Fixes: f16a9d7 ("regulator: bd71828: Support ROHM BD72720") Link: https://patch.msgid.link/e7eef0bd407522ae5d9b7d0c4ec43f40b1dba833.1775565148.git.mazziesaccount@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 591cd65 commit b1baaff

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/regulator/bd71828-regulator.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -785,7 +785,7 @@ static const struct bd71828_regulator_data bd71828_rdata[] = {
785785
},
786786
};
787787

788-
#define BD72720_BUCK10_DESC_INDEX 10
788+
#define BD72720_BUCK10_DESC_INDEX 9
789789
#define BD72720_NUM_BUCK_VOLTS 0x100
790790
#define BD72720_NUM_LDO_VOLTS 0x100
791791
#define BD72720_NUM_LDO12346_VOLTS 0x80

0 commit comments

Comments
 (0)