dmaengine: idxd: Fix not releasing workqueue on .release()

vcgomes · vinodkoul · commit 3d33de353b1f · 2026-02-25T16:39:18.000+05:30
The workqueue associated with an DSA/IAA device is not released when the object is freed. Fixes: 47c16ac ("dmaengine: idxd: fix idxd conf_dev 'struct device' lifetime") Reviewed-by: Dave Jiang <dave.jiang@intel.com> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> Link: https://patch.msgid.link/20260121-idxd-fix-flr-on-kernel-queues-v3-v3-7-7ed70658a9d1@intel.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c
@@ -1836,6 +1836,7 @@ static void idxd_conf_device_release(struct device *dev)
 {
 	struct idxd_device *idxd = confdev_to_idxd(dev);
 
+	destroy_workqueue(idxd->wq);
 	kfree(idxd->groups);
 	bitmap_free(idxd->wq_enable_map);
 	kfree(idxd->wqs);

Original file line number	Diff line number	Diff line change
`@@ -1836,6 +1836,7 @@ static void idxd_conf_device_release(struct device *dev)`
`1836`	`1836`	`{`
`1837`	`1837`	`struct idxd_device *idxd = confdev_to_idxd(dev);`
`1838`	`1838`
	`1839`	`+ destroy_workqueue(idxd->wq);`
`1839`	`1840`	`kfree(idxd->groups);`
`1840`	`1841`	`bitmap_free(idxd->wq_enable_map);`
`1841`	`1842`	`kfree(idxd->wqs);`