Skip to content

MSVC: wxGetApp() used in GUI_Utils.hpp breaks the Windows build after the dark-mode selector #609

Description

@BenJule

The Windows Actions build on build/2.8.0-beta fails with C2039/C3861 at GUI_Utils.hpp(205): 'wxGetApp' is not a member of 'Slic3r::GUI'.

The dark-mode selector commit (20a736d) added a wxEVT_SYS_COLOUR_CHANGED handler in the header whose #ifdef WINDOWS branch calls GUI::wxGetApp().app_config — but GUI_Utils.hpp neither includes GUI_App.hpp (circular) nor sees a declaration. Linux builds never compile that branch, which is why the integration verification (Jenkins build #14) stayed green.

Plan: declare a small free function in the header and implement it in GUI_Utils.cpp, which already includes GUI_App.hpp.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions