fix: node particle system size creation to support centimeters by default

Author: julien-moreau

editor/src/editor/layout/assets-browser.tsx

@@ -804,10 +804,11 @@ export class EditorAssetsBrowser extends Component<IEditorAssetsBrowserProps, IE
 					</ContextMenuSubContent>
 				</ContextMenuSub>
 
+				<ContextMenuSeparator />
+				<ContextMenuItem onClick={() => this._handleAddNodeParticleSystem()}>Node Particle System</ContextMenuItem>
+
 				{this.props.editor.state.enableExperimentalFeatures && (
 					<>
-						<ContextMenuSeparator />
-						<ContextMenuItem onClick={() => this._handleAddNodeParticleSystem()}>Node Particle System</ContextMenuItem>
 						<ContextMenuSeparator />
 						<ContextMenuItem onClick={() => this._handleAddCinematic()}>Cinematic</ContextMenuItem>
 						<ContextMenuSeparator />

editor/src/editor/nodes/node-particle-system.ts

@@ -21,6 +21,9 @@ export class NodeParticleSystemSetMesh extends Mesh {
 	 */
 	public constructor(name: string, scene: Scene, parent?: Node | null, source?: Mesh, doNotCloneChildren?: boolean, clonePhysicsImpostor?: boolean) {
 		super(name, scene, parent, source, doNotCloneChildren, clonePhysicsImpostor);
+
+		// Set scale to 100 as default unit size is centimeters and particles are in meters
+		this.scaling.setAll(100);
 	}
 
 	public async buildNodeParticleSystemSet(data: any): Promise<void> {
@@ -47,6 +50,17 @@ export class NodeParticleSystemSetMesh extends Mesh {
 			particleSystem.id = Tools.RandomId();
 			particleSystem.uniqueId = UniqueNumber.Get();
 
+			if (isParticleSystem(particleSystem)) {
+				const sizeCreationProcess = particleSystem._sizeCreation.process;
+				if (sizeCreationProcess) {
+					particleSystem._sizeCreation.process = (particle, system) => {
+						sizeCreationProcess(particle, system);
+						particle.scale.x *= 100;
+						particle.scale.y *= 100;
+					};
+				}
+			}
+
 			if (isParticleSystem(particleSystem) || isGPUParticleSystem(particleSystem)) {
 				setParticleSystemVisibleInGraph(particleSystem, false);
 			}

tools/src/loading/node-particle-system-set.ts

@@ -3,6 +3,7 @@ import { AssetContainer } from "@babylonjs/core/assetContainer";
 import { AddParser } from "@babylonjs/core/Loading/Plugins/babylonFileParser.function";
 import { NodeParticleSystemSet } from "@babylonjs/core/Particles/Node/nodeParticleSystemSet";
 
+import { isParticleSystem } from "../tools/guards";
 import { NodeParticleSystemMesh } from "../tools/particle";
 
 let registered = false;
@@ -40,6 +41,19 @@ export function registerNodeParticleSystemSetParser() {
 				scene.removePendingData(mesh.id);
 				instance.particleSystemSet = particleSystemSet;
 
+				particleSystemSet.systems.forEach((particleSystem) => {
+					if (isParticleSystem(particleSystem)) {
+						const sizeCreationProcess = particleSystem._sizeCreation.process;
+						if (sizeCreationProcess) {
+							particleSystem._sizeCreation.process = (particle, system) => {
+								sizeCreationProcess(particle, system);
+								particle.scale.x *= 100;
+								particle.scale.y *= 100;
+							};
+						}
+					}
+				});
+
 				particleSystemSet.emitterNode = instance;
 				particleSystemSet.start();
 			});