Skip to content

Commit 24eb61b

Browse files
committed
fix: override sprite renderer for visual feedback in preview
1 parent d0f9f66 commit 24eb61b

2 files changed

Lines changed: 11 additions & 3 deletions

File tree

editor/src/editor/layout/inspector/fields/number.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,13 @@ export function EditorInspectorNumberField(props: IEditorInspectorNumberFieldPro
3737
const step = props.step ?? 0.01;
3838
const digitCount = props.step?.toString().split(".")[1]?.length ?? 2;
3939

40-
let startValue = getStartValue();
41-
4240
const [value, setValue] = useState<string>(getStartValue());
4341
const [oldValue, setOldValue] = useState<string>(getStartValue());
4442

4543
useEffect(() => {
4644
setValue(getStartValue());
4745
setOldValue(getStartValue());
48-
}, [props.object, props.property, props.step, startValue]);
46+
}, [props.object, props.property, props.step]);
4947

5048
useEventListener("keydown", (ev) => {
5149
if (ev.key === "Shift") {

editor/src/editor/nodes/sprite-manager.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ export class SpriteManagerNode extends TransformNode {
8585
if (serializeSpriteManager) {
8686
this._parseSpriteManager(serializeSpriteManager);
8787
}
88+
89+
this._overrideSpriteRenderer();
8890
}
8991

9092
public buildFromAtlasJsonAbsolutePath(absolutePath: string, serializeSpriteManager?: any): void {
@@ -113,6 +115,8 @@ export class SpriteManagerNode extends TransformNode {
113115
if (serializeSpriteManager) {
114116
this._parseSpriteManager(serializeSpriteManager);
115117
}
118+
119+
this._overrideSpriteRenderer();
116120
}
117121

118122
public disposeSpriteManager(): void {
@@ -152,6 +156,12 @@ export class SpriteManagerNode extends TransformNode {
152156
sprite.uniqueId = parsedSprite.uniqueId;
153157
sprite.metadata = parsedSprite.metadata;
154158
}
159+
}
160+
161+
private _overrideSpriteRenderer(): void {
162+
if (!this.spriteManager) {
163+
return;
164+
}
155165

156166
const spriteRenderer = this.spriteManager.spriteRenderer;
157167

0 commit comments

Comments
 (0)