From 4c62cd338c25d2e27d5d213984dcad74f881eb09 Mon Sep 17 00:00:00 2001
From: DB Lee <donlee@microsoft.com>
Date: Mon, 23 Mar 2026 17:51:05 -0700
Subject: [PATCH] fix: -f all now generates both md and html reports

ReportResult now carries an optional html_report_path so the CLI
can display both output paths when report_format is 'all'.
---
 src/agentops/cli/app.py            | 16 +++++++++-------
 src/agentops/services/reporting.py |  4 ++++
 2 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/src/agentops/cli/app.py b/src/agentops/cli/app.py
index a77bcdd3..a9f9e7bd 100644
--- a/src/agentops/cli/app.py
+++ b/src/agentops/cli/app.py
@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 from pathlib import Path
-from typing import Annotated, Optional
+from typing import Annotated
 
 import typer
 
@@ -137,7 +137,7 @@ def cmd_init(
 @eval_app.command("run")
 def cmd_eval_run(
     config: Annotated[
-        Optional[Path],
+        Path | None,
         typer.Option(
             "--config",
             "-c",
@@ -145,7 +145,7 @@ def cmd_eval_run(
         ),
     ] = None,
     output: Annotated[
-        Optional[Path],
+        Path | None,
         typer.Option("--output", "-o", help="Output directory for results."),
     ] = None,
     report_format: Annotated[
@@ -191,7 +191,7 @@ def cmd_eval_compare(
         ),
     ],
     output: Annotated[
-        Optional[Path],
+        Path | None,
         typer.Option("--output", "-o", help="Output directory for comparison results."),
     ] = None,
     report_format: Annotated[
@@ -250,7 +250,7 @@ def cmd_eval_compare(
 def cmd_report(
     ctx: typer.Context,
     results_in: Annotated[
-        Optional[Path],
+        Path | None,
         typer.Option(
             "--in",
             help=(
@@ -260,7 +260,7 @@ def cmd_report(
         ),
     ] = None,
     report_out: Annotated[
-        Optional[Path],
+        Path | None,
         typer.Option("--out", help="Output path for report."),
     ] = None,
     report_format: Annotated[
@@ -294,6 +294,8 @@ def cmd_report(
 
     typer.echo(f"Loaded results: {report_result.input_results_path}")
     typer.echo(f"Generated report: {report_result.output_report_path}")
+    if report_result.html_report_path:
+        typer.echo(f"Generated report: {report_result.html_report_path}")
 
 
 @report_app.command("show")
@@ -324,7 +326,7 @@ def cmd_run_show() -> None:
 def cmd_run_view(
     run_id: str,
     entry: Annotated[
-        Optional[int],
+        int | None,
         typer.Option("--entry", help="Optional row/entry index for deep inspection."),
     ] = None,
 ) -> None:
diff --git a/src/agentops/services/reporting.py b/src/agentops/services/reporting.py
index 5d317544..e3995e33 100644
--- a/src/agentops/services/reporting.py
+++ b/src/agentops/services/reporting.py
@@ -14,6 +14,7 @@
 class ReportResult:
     input_results_path: Path
     output_report_path: Path
+    html_report_path: Path | None = None
 
 
 def generate_report_from_results(
@@ -35,6 +36,7 @@ def generate_report_from_results(
     resolved_output_path.parent.mkdir(parents=True, exist_ok=True)
 
     primary_path = resolved_output_path
+    html_report_path: Path | None = None
     if report_format in ("md", "all"):
         md_path = (
             resolved_output_path
@@ -47,10 +49,12 @@ def generate_report_from_results(
         html_path = resolved_output_path.with_suffix(".html")
         html_path.write_text(generate_report_html(result), encoding="utf-8")
         primary_path = html_path
+        html_report_path = html_path
     if report_format == "all":
         primary_path = resolved_output_path.with_suffix(".md")
 
     return ReportResult(
         input_results_path=resolved_results_path,
         output_report_path=primary_path,
+        html_report_path=html_report_path,
     )