Skip to content

Commit b02e333

Browse files
committed
update deps and popper refs
1 parent 085de12 commit b02e333

7 files changed

Lines changed: 13 additions & 12 deletions

File tree

1-Authentication/3-sign-in-electron/App/AuthProvider.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@ class AuthProvider {
1919
* https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-node/docs/initialize-public-client-application.md
2020
*/
2121
this.msalConfig = msalConfig;
22+
console.log(this.msalConfig);
2223
this.clientApplication = new PublicClientApplication(this.msalConfig);
24+
console.log(this.clientApplication);
2325
this.cache = this.clientApplication.getTokenCache();
2426
this.account = null;
2527
}

1-Authentication/3-sign-in-electron/App/authConfig.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,8 @@ const TENANT_SUBDOMAIN = 'Enter_the_Tenant_Subdomain_Here';
1414
*/
1515
const msalConfig = {
1616
auth: {
17-
// clientId: 'Enter_the_Application_Id_Here',
18-
// authority: `https://${TENANT_SUBDOMAIN}.ciamlogin.com/`, // Replace the placeholder with your tenant subdomain,
19-
clientId: '94fc755a-af32-43f9-9ce6-5f86f2beb928', // This is the ONLY mandatory field that you need to supply.
20-
authority: 'https://TrialTenantkwFwHYij.ciamlogin.com//', // Replace the placeholder with your tenant subdomain
17+
clientId: 'Enter_the_Application_Id_Here',
18+
authority: `https://${TENANT_SUBDOMAIN}.ciamlogin.com/`, // Replace the placeholder with your tenant subdomain,
2119
},
2220
system: {
2321
loggerOptions: {

1-Authentication/3-sign-in-electron/App/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ <h5 class="card-header text-center" id="WelcomeMessage">Welcome to the Microsoft
5252

5353
<!-- importing bootstrap.js and supporting js libraries -->
5454
<script src="./node_modules/jquery/dist/jquery.js"></script>
55-
<script src=".node_modules/@popperjs/core/dist/umd/popper.js"></script>
55+
<script src="./node_modules/@popperjs/core/dist/umd/popper.min.js"></script>
5656
<script src="./node_modules/bootstrap/dist/js/bootstrap.js"></script>
5757

5858
<!-- importing app scripts | load order is important -->

1-Authentication/3-sign-in-electron/App/package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

1-Authentication/3-sign-in-electron/App/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
},
1010
"license": "ISC",
1111
"devDependencies": {
12-
"electron": "^31.0.1"
12+
"electron": "^29.1.6"
1313
},
1414
"dependencies": {
1515
"@azure/msal-node": "^2.9.2",

1-Authentication/3-sign-in-electron/AppCreationScripts/apps.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,5 @@
4444
]
4545
}
4646
]
47-
}
47+
}
48+

1-Authentication/3-sign-in-electron/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ Open the project in your IDE (like Visual Studio or Visual Studio Code) to confi
186186
> In the steps below, "ClientID" is the same as "Application ID" or "AppId".
187187
188188
1. Open the `App\authConfig.js` file.
189-
1. Find the placeholder `Enter_the_Tenant_Subdomain_Here` and replace it with the Directory (tenant) subdomain. For instance, if your tenant primary domain is `contoso.onmicrosoft.com`, use `contoso`. If you don't have your tenant domain name, learn how to [read your tenant details](https://review.learn.microsoft.com/azure/active-directory/external-identities/customers/how-to-create-customer-tenant-portal#get-the-customer-tenant-details).
189+
1. Find the two placeholders named `Enter_the_Tenant_Subdomain_Here` and replace them with the Directory (tenant) subdomain. For instance, if your tenant primary domain is `contoso.onmicrosoft.com`, use `contoso`. If you don't have your tenant domain name, learn how to [read your tenant details](https://review.learn.microsoft.com/azure/active-directory/external-identities/customers/how-to-create-customer-tenant-portal#get-the-customer-tenant-details).
190190
1. Find the key `Enter_the_Application_Id_Here` and replace the existing value with the application ID (clientId) of `msal-node-desktop` app copied from the Azure portal.
191191
192192
### Step 4: Running the sample

0 commit comments

Comments
 (0)