Merge pull request #105 from Azure-Samples/algo-1/fix-vulnerabilities

Algo 1/fix vulnerabilities

Author: algo-1

1-Authentication/0-sign-in-vanillajs/App/package-lock.json

@@ -1,18 +1,13 @@
 // Create the main myMSALObj instance
 // configuration parameters are located at authConfig.js
-const myMSALObj = new msal.PublicClientApplication(msalConfig);
-
-myMSALObj.initialize().then(() => {
-    /**
-     * A promise handler needs to be registered for handling the
-     * response returned from redirect flow. For more information, visit:
-     * https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-browser/docs/initialization.md#redirect-apis
-     */
-    myMSALObj.handleRedirectPromise()
-        .then(handleResponse)
-        .catch((error) => {
-            console.error(error);
-        });
+let myMSALObj;
+
+msal.PublicClientApplication.createPublicClientApplication(msalConfig)
+    .then((obj) => {
+        myMSALObj = obj;
+    })
+    .catch((error) => {
+        console.error("Error creating MSAL PublicClientApplication:", error);
     });
 
 let username = "";

1-Authentication/0-sign-in-vanillajs/App/public/authPopup.js

@@ -1,19 +1,22 @@
 // Create the main myMSALObj instance
 // configuration parameters are located at authConfig.js
-const myMSALObj = new msal.PublicClientApplication(msalConfig);
-
-myMSALObj.initialize().then(() => {
-/**
- * A promise handler needs to be registered for handling the
- * response returned from redirect flow. For more information, visit:
- * https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-browser/docs/initialization.md#redirect-apis
- */
-myMSALObj.handleRedirectPromise()
-    .then(handleResponse)
+msal.PublicClientApplication.createPublicClientApplication(msalConfig)
+    .then((obj) => {
+        myMSALObj = obj;
+        /**
+         * A promise handler needs to be registered for handling the
+         * response returned from redirect flow. For more information, visit:
+         * https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-browser/docs/initialization.md#redirect-apis
+         */
+        myMSALObj.handleRedirectPromise()
+        .then(handleResponse)
+        .catch((error) => {
+            console.error(error);
+        });
+    })
     .catch((error) => {
-        console.error(error);
+        console.error("Error creating MSAL PublicClientApplication:", error);
     });
-});
 
 let username = "";
 

1-Authentication/0-sign-in-vanillajs/App/public/authRedirect.js

@@ -5,6 +5,7 @@
     "dependencies": {
         "@azure/msal-browser": "^3.17.0",
         "@azure/msal-react": "^2.0.19",
+        "@babel/plugin-transform-private-property-in-object": "^7.24.7",
         "@testing-library/jest-dom": "^6.4.6",
         "@testing-library/react": "^16.0.0",
         "@testing-library/user-event": "^14.5.2",
@@ -14,7 +15,6 @@
         "react-dom": "^18.3.1"
     },
     "devDependencies": {
-        "@babel/plugin-transform-private-property-in-object": "^7.24.7",
         "react-scripts": "^5.0.1"
     },
     "scripts": {